Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Next #835

Merged
merged 29 commits into from
Apr 11, 2023
Merged

Next #835

merged 29 commits into from
Apr 11, 2023

Conversation

oscard0m
Copy link
Member

@oscard0m oscard0m commented Apr 8, 2023 •
edited by wolfy1339
Loading

Resolves #819

wolfy1339 and others added 26 commits April 6, 2023 18:09
@wolfy1339
build: replace pika with esbuild and tsc
e178758 
Pika has been deprecated for a while now, and the project has now been achived.

Uses esbuild to transpile the TS source code into an ESM source, NodeJs bundle, and a browser bundle

Uses the TypeScript compiler to generate the types
@wolfy1339
build: delete the pkg folder to start with a clean slate
8a76b4c
@wolfy1339
build: don't include node_modules in bundles
cc857ca
@wolfy1339
build: use index.js as the sole bundle entry point
14fd14e 
This way we end up with only a single file
@wolfy1339
build: use fs.rm() instead of fs.rmDir()
c0f5d38
@wolfy1339
build: delete the type.js files
6d1f542 
Those files aren't needed, they only contain comments
@wolfy1339
build: optimise glob usage
c047d59
@wolfy1339
style: run prettier
40dd9b6
@wolfy1339
build: also remove map files
9841e21
@wolfy1339
build: add comments to the build script
84fb0bb
@wolfy1339 @oscard0m
Update scripts/build.ts
4eb2fa9 
Co-authored-by: Oscar Dominguez <dominguez.celada@gmail.com>
@wolfy1339
build: use Promise.all()
2ef22c1 
This can help speed up the build times
@wolfy1339
build: use Promise api for fs modules
e8742a9
@wolfy1339
build: switch to async glob
0c21120
@wolfy1339
build: switch to plain JS file
1d8c641
@wolfy1339
chore: update .gitignore comment
fab2020
@wolfy1339
build: fix script in package.json
51d322a
@wolfy1339
build: reduce glob expression
e37ce43
@wolfy1339
build: don't use ./ in paths in package.json
7ddc8ca
@wolfy1339 @oscard0m
Update scripts/build.mjs
645b820 
Co-authored-by: Oscar Dominguez <dominguez.celada@gmail.com>
@wolfy1339 @oscard0m
Update scripts/build.mjs
d6ca30a 
Co-authored-by: Oscar Dominguez <dominguez.celada@gmail.com>
@wolfy1339 @oscard0m
Apply suggestions from code review
285af7d 
Co-authored-by: Oscar Dominguez <dominguez.celada@gmail.com>
@wolfy1339
style: run prettier
3f591ae
@wolfy1339
fix: empty commit to trigger release
34ef02d
@oscard0m
fix(build): serve types from dist-types/index.d.ts
9168bd6
@oscard0m
fix(build): include sourceContent in node/browser bundles
823dbfb
@oscard0m oscard0m added the Type: Bug Something isn't working as documented, or is being fixed label Apr 8, 2023
@oscard0m oscard0m requested a review from wolfy1339 April 8, 2023 07:48
@oscard0m
Copy link
Member Author

oscard0m commented Apr 8, 2023 •
edited
Loading

I wonder if this branch has different protection rules for merging @wolfy1339
I think the configuration is at repository level and not per branch but let's try.

wolfy1339
wolfy1339 previously approved these changes Apr 8, 2023
View reviewed changes
@wolfy1339
Copy link
Member

The problem is that the main branch is protected.

wolfy1339
wolfy1339 previously approved these changes Apr 10, 2023
View reviewed changes
@wolfy1339
Copy link
Member

Replaces #819

@kfcampbell kfcampbell mentioned this pull request Apr 10, 2023
Closed
@kfcampbell kfcampbell merged commit 3086878 into main Apr 11, 2023
@kfcampbell kfcampbell deleted the next branch April 11, 2023 23:33
@github-actions
Copy link
Contributor

🎉 This PR is included in version 11.0.0-beta.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link
Contributor

🎉 This PR is included in version 10.9.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions GitHub Actions
Copy link
Contributor

🎉 This PR is included in version 10.9.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kfcampbell kfcampbell kfcampbell approved these changes

@wolfy1339 wolfy1339 wolfy1339 left review comments

Assignees
No one assigned
Labels
released on @beta released on @10.x released Type: Bug Something isn't working as documented, or is being fixed
Projects
🧰 Octokit Active
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oscard0m @wolfy1339 @kfcampbell