You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Different types exposes similar properties using different underlying types, I was looking at the *_at properties in the class WorkflowJob and seems like those properties are exposed as string while most of the time they're exposes as DateTimeOffset.
Having a quick look here I found some more occurrences here and here
Can we unify those and use DateTimeOffset everywhere? This will be a breaking change so it requires a major version bump.
Versions
2.2.2
Relevant log output
No response
Code of Conduct
I agree to follow this project's Code of Conduct
The text was updated successfully, but these errors were encountered:
👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀
@ilmax thanks for opening the bug. I think #525 resolves this, but I agree that this is a breaking change. I'll see if we have any more immediate breaking changes that we want to batch together into a 3.0.0 release.
What happened?
Different types exposes similar properties using different underlying types, I was looking at the
*_at
properties in the classWorkflowJob and seems like those properties are exposed as string while most of the time they're exposes as
DateTimeOffset
.Having a quick look here I found some more occurrences here and here
Can we unify those and use
DateTimeOffset
everywhere? This will be a breaking change so it requires a major version bump.Versions
2.2.2
Relevant log output
No response
Code of Conduct
The text was updated successfully, but these errors were encountered: