-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add workflow_run:completed
webhook, set empty client_payload
for workflow_dispatch
webhook
#139
feat: add workflow_run:completed
webhook, set empty client_payload
for workflow_dispatch
webhook
#139
Conversation
client_payload
for workflow_dispatch
webhookworkflow_run:completed
webhook, set empty client_payload
for workflow_dispatch
webhook
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do not edit the index.json
file because it's generated. Instead add and update the example files and run bin/octokit-webhooks.js update
, otherwise all the changes will be reverted within an hour via the update
workflow
@@ -20593,16 +20593,13 @@ | |||
}, | |||
{ | |||
"name": "repository_dispatch", | |||
"description": "This event occurs when a GitHub App sends a `POST` request to the \"[Create a repository dispatch event](https://docs.github.com/en/v3/repos/#create-a-repository-dispatch-event)\" endpoint.\n\nGitHub Apps must have the `contents` permission to receive this webhook.", | |||
"description": "This event occurs when a GitHub App sends a `POST` request to the \"[Create a repository dispatch event](https://docs.github.com/en/v3/repos/#create-a-repository-dispatch-event)\" endpoint.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the description is directly parsed from the website, this change will be reverted with next next automated update
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't edited index.json
manually – I ran bin/octokit-webhooks.js update
and that's what was generated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I can see, they've recently moved this note to a separate section: https://docs.github.com/en/developers/webhooks-and-events/webhook-events-and-payloads#availability-35.
@gr2m, the schedule section of the webhooks/.github/workflows/update.yml Lines 2 to 4 in b4ece11
|
oopsies, that should have been uncommented as part of #134. When you ran |
Done 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot!
🎉 This PR is included in version 3.12.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Hi!
Just a minor thing, but it still looks worth fixing while I battle the JSON Schema :)