fix(schemas): remove 'email' format for 'email' property in committer.schema.json #678
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
format: email
for"email"
property incommitter.schema.json
index.json
Context
emails aren't compliant with the RFC, not because of anything related to the JSON schema itself.
RFC 5322 Section 3.4 defines valid email addresses here: https://datatracker.ietf.org/doc/html/rfc5322#section-3.4
Example of not supported format:
41898282+github-actions
[bot
]@users.noreply.github.com
Fixes #453
Alternative solutions
To use the existing
pattern
fromajv-format
for email and cover the use-case of emails. (#677)Discussion on-going in #453