Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mark action as required in secret_scanning_alert_location.created event #801

Merged
merged 1 commit into from
May 28, 2023

Conversation

wolfy1339
Copy link
Member

Resolves #ISSUE_NUMBER


Behavior

Before the change?

  • The action property wasn't set as required and thus was generating as potentially undefined

After the change?

  • Marks the action property as required

Other information


Additional info

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Added the appropriate label for the given change

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes (Please add the Type: Breaking change label)
  • No

If Yes, what's the impact:

  • N/A

Pull request type

Please add the corresponding label for change this PR introduces:

  • Bugfix: Type: Bug

@wolfy1339 wolfy1339 added the Type: Bug Something isn't working as documented label May 27, 2023
@wolfy1339 wolfy1339 merged commit 39fb367 into main May 28, 2023
@wolfy1339 wolfy1339 deleted the fix-action-undefined branch May 28, 2023 02:17
@octokitbot
Copy link
Collaborator

🎉 This PR is included in version 7.0.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Type: Bug Something isn't working as documented
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants