🐛 fix(type-declaration): export WebhookDefinition type for external usage #83

oscard0m · 2020-04-10T20:54:41Z

📝 Summary

Export type WebhookDefinition for usage on third party projects

⛱ Motivation and Context

This migration needs WebhookDefinition types exposed.
Blocked by 📦 refactor(ping-webhook): replace 'example' for 'examples' for consistency with the resto webhooks #82 to avoid problems of examples 🆚 example property on type WebhookDefinition

📚 References:

TypeScript migration of webhooks.js: feat(TypeScript): Webhook events are now an enum instead of a list of strings. Webhook event name types can be imported as EventNames webhooks.js#113

…sage

github-actions · 2020-04-12T18:35:41Z

🎉 This PR is included in version 3.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

🐛 fix(type-declaration): export WebhookDefinition type for external u…

7a270d1

…sage

oscard0m mentioned this pull request Apr 10, 2020

feat(TypeScript): Webhook events are now an enum instead of a list of strings. Webhook event name types can be imported as EventNames octokit/webhooks.js#113

Merged

gr2m approved these changes Apr 12, 2020

View reviewed changes

gr2m merged commit da88ca9 into octokit:master Apr 12, 2020

github-actions bot added the released label Apr 12, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🐛 fix(type-declaration): export WebhookDefinition type for external usage #83

🐛 fix(type-declaration): export WebhookDefinition type for external usage #83

oscard0m commented Apr 10, 2020 •

edited

Loading

github-actions bot commented Apr 12, 2020

🐛 fix(type-declaration): export WebhookDefinition type for external usage #83

🐛 fix(type-declaration): export WebhookDefinition type for external usage #83

Conversation

oscard0m commented Apr 10, 2020 • edited Loading

📝 Summary

⛱ Motivation and Context

📚 References:

github-actions bot commented Apr 12, 2020

oscard0m commented Apr 10, 2020 •

edited

Loading