feat: event descriptions #98
Conversation
index.json
Outdated
| "actions": [ | ||
| "completed", | ||
| "created", | ||
| "requested_action", |
There was a problem hiding this comment.
I'm looking into why this is happening
index.json
Outdated
| "actions": [ | ||
| "assigned", | ||
| "closed", | ||
| "edited", | ||
| "labeled", | ||
| "locked", | ||
| "merged", |
There was a problem hiding this comment.
@gr2m this one got added too FYI
There was a problem hiding this comment.
ah thanks for the pointer, merged is not a valid action
|
@zeke I mentioned this to @gr2m and it sounded like it wouldn't impact this work significantly, but I've moved and reworked that page a bit in https://github.com/github/internal-developer.github.com/pull/6352. I'm hoping to ship that this week, but I can hold on shipping it if it will cause significant changes to your work here. |
… `pull_request.merged`
|
Thanks for the heads-up @rachmari. I will defer to Gregor's judgement on that. |
gr2m
force-pushed
the
update-section-parser
branch
from
e06f885
to
70d24e6
Compare
|
🎉 This PR is included in version 3.8.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
That was quick! Thanks for the cleanup @gr2m 🙌 |
This PR updates the build process to extract descriptions from the events listed at https://developer.github.com/v3/activity/events/types/
Notes:
turndown, following prior art from other Octokit projects/v3are rewritten as fully-qualifieddeveloper.git.luolix.topURLsajvto validate the shape of each extracted webhook object.section-to-webhook.jsto make it easier to read and refine. I was also able to remove some workarounds around quoted action names that were no longer necessary.pull_request.synchronizewhich is no longer needed.cc @rachmari @sarahs @bswinnerton @JasonEtco
Resolves #89