Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add authorship and acknowledgements retrieved from the backend #70

Open
volodymyrss opened this issue Sep 6, 2023 · 9 comments
Open
Assignees

Comments

@volodymyrss
Copy link
Member

volodymyrss commented Sep 6, 2023

need to use all authors

can add extra metadata by adding this to parameters cell:

# oda:author_name "Marco Tucci" .
@dsavchenko
Copy link
Member

Concerning acknowledgements, it's implemented in oda-hub/oda-bot#27 via adding a file acknowledgements.md to the repo.

@dsavchenko
Copy link
Member

Adding either authorship or acknowledgements text via annotations to the .ipynb have a disadvantage: they should be the same throughout the repo, as different notebooks correspond to different 'products' of the same instrument

@volodymyrss
Copy link
Member Author

I might be better to eventually provide it from backend, this would allow to expose it in oda-api too. If we add authors anyway, we could as well add acknowledgements.

@volodymyrss
Copy link
Member Author

Adding either authorship or acknowledgements text via annotations to the .ipynb have a disadvantage: they should be the same throughout the repo, as different notebooks correspond to different 'products' of the same instrument

if returned from the backend it can be done per product. But ok, maybe it can be on oda.yaml or something.

@dsavchenko
Copy link
Member

if returned from the backend it can be done per product

It's implemented per-instrument in the frontend. It's unlikely to have a need in per-prod authorship.

@dsavchenko
Copy link
Member

Still, it will be good to have all this info via oda_api. Just requires changes both in dispatcher and in oda_api. Then, all 'static' plugins will need to be updated with the info

@volodymyrss
Copy link
Member Author

if returned from the backend it can be done per product

It's implemented per-instrument in the frontend. It's unlikely to have a need in per-prod authorship.

Is it really? It is shown along with product.

@dsavchenko
Copy link
Member

@volodymyrss
Copy link
Member Author

I guess it was just a workaround. It was put near the product for a reason. But, for now, we can just put it per instrument.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants