-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add authorship and acknowledgements retrieved from the backend #70
Comments
Concerning acknowledgements, it's implemented in oda-hub/oda-bot#27 via adding a file |
Adding either authorship or acknowledgements text via annotations to the .ipynb have a disadvantage: they should be the same throughout the repo, as different notebooks correspond to different 'products' of the same instrument |
I might be better to eventually provide it from backend, this would allow to expose it in oda-api too. If we add authors anyway, we could as well add acknowledgements. |
if returned from the backend it can be done per product. But ok, maybe it can be on oda.yaml or something. |
It's implemented per-instrument in the frontend. It's unlikely to have a need in per-prod authorship. |
Still, it will be good to have all this info via oda_api. Just requires changes both in dispatcher and in oda_api. Then, all 'static' plugins will need to be updated with the info |
Is it really? It is shown along with product. |
But it's set for the whole instrument on installation e.g. https://github.com/oda-hub/mmoda-frontend-module/blob/3d6ee66289a9865ef83315aeb4da4c788412a1a6/instruments/mmoda_antares/mmoda_antares.install#L46 |
I guess it was just a workaround. It was put near the product for a reason. But, for now, we can just put it per instrument. |
need to use all authors
can add extra metadata by adding this to
parameters
cell:The text was updated successfully, but these errors were encountered: