Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build Odigos collector and run unit tests in PRs #1463

Merged
merged 8 commits into from
Aug 26, 2024

Conversation

RonFed
Copy link
Collaborator

@RonFed RonFed commented Aug 25, 2024

No description provided.

Copy link
Collaborator

@tamirdavid1 tamirdavid1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

general question


tests:
expect_consumer_error: true
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What the idea of it?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When using the unit tests which are auto-generated by the mdatagen tool, we can't really export to azure/googlecloud - so this is a way to configure the tool to avoid this check in the tests.
In general, the exporters' tests did problems and they are not being run in CI (currently only the processors tests are running in CI).

@RonFed RonFed merged commit 6c05153 into odigos-io:main Aug 26, 2024
22 checks passed
@RonFed RonFed deleted the odigos_collector_build_ci branch August 26, 2024 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants