os2.is_file not working

[SrMordred]

Context

os2.is_file are not working on windows

• Operating System & Odin Version:

        Odin:    dev-2024-10-nightly:af9ae48
        OS:      Windows 11 Professional (version: 22H2), build 22621.4317
        CPU:     AMD Ryzen 5 1600 Six-Core Processor
        RAM:     16313 MiB
        Backend: LLVM 18.1.8

Expected Behavior

Same as os.is_file

Current Behavior

Unable to get the file type properly

this function gets the file type, but on

Odin/core/os/os2/stat_windows.odin

Line 197 in b82f8df

_file_type_mode_from_file_attributes :: proc(file_attributes: win32.DWORD, h: win32.HANDLE, ReparseTag: win32.DWORD) -> (type: File_Type, mode: int) {

the file handle are nil. Causing file_type to return .Undetermined.

Odin/core/os/os2/stat_windows.odin

Line 225 in b82f8df

type, mode := _file_type_mode_from_file_attributes(d.dwFileAttributes, nil, 0)

Since the file type that are compared here, it returns false for existing files.

Odin/core/os/os2/file.odin

Line 294 in b82f8df

return fi.type == .Regular

[flysand7]

Uh oh, the git blame shows me as the culprit... I was messing around with type info and might have broken (did it work?) the stat. I'd have to think about this one before submitting a fix.