Disable Reset button while download is in progress and vice versa. #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? Also need an authorization to run tests. |
|
runtests |
wbrunette
requested changes
Mar 25, 2021
|
Thanks for the suggestions @wbrunette , I have implemented some changes and tried to make it more descriptive . |
|
@Shubhamr837 It is still not very clear what the parameters do just looking at the parameters. Perhaps you could replace the boolean with an enum? |
|
Thanks for this idea @linl33 , I have implemented the changes . Please review and suggest if any improvement is possible . |
Shubhamr837
commented
Mar 30, 2021
Shubhamr837
commented
Mar 30, 2021
linl33
requested changes
Mar 31, 2021
|
Thanks @linl33 , I have added a method in the enum to simplify this . Please review |
linl33
approved these changes
Apr 1, 2021
wbrunette
approved these changes
Apr 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setButtonState() method is added in the IOPanel class .
It is used by both the tabs to toggle the visibility of the buttons of each other .
should fix odk-x/tool-suite-X#219