Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suitcase errors on selecting reset option while download is in progress #219

Closed
Shubhamr837 opened this issue Mar 23, 2021 · 3 comments · Fixed by odk-x/suitcase#51
Closed
Assignees
Labels
bug Something isn't working Suitcase ODK-X Suitcase

Comments

@Shubhamr837
Copy link

Shubhamr837 commented Mar 23, 2021

Software and hardware versions
ODK-X Suitcase v2.1.7

Problem description
Suitcase logs an error Message if Reset option is clicked from the upload tab in GUI while download is in progress . This happens because files get deleted while being downloaded.

error message for table_id "geotagger" :
java.lang.IllegalArgumentException: tableId: geotagger does not exist at org.opendatakit.suitcase.net.SyncWrapper.batchGetFilesForRow(SyncWrapper.java:261) at org.opendatakit.suitcase.net.AttachmentManager.downloadAttachments(AttachmentManager.java:123) at org.opendatakit.suitcase.model.ODKCsv.getData(ODKCsv.java:533) at org.opendatakit.suitcase.model.ODKCsv.get(ODKCsv.java:308) at org.opendatakit.suitcase.model.ODKCsv$ODKCSVIterator.next(ODKCsv.java:48) at org.opendatakit.suitcase.net.DownloadTask.doInBackground(DownloadTask.java:89) at org.opendatakit.suitcase.net.DownloadTask.doInBackground(DownloadTask.java:23) at java.desktop/javax.swing.SwingWorker$1.call(SwingWorker.java:304) at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264) at java.desktop/javax.swing.SwingWorker.run(SwingWorker.java:343) at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128) at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628) at java.base/java.lang.Thread.run(Thread.java:834)

Steps to reproduce the problem

Open suitcase and login.
Enter a table_id to download , check the download attachments option as true ( This results in download taking more time ) and click download .
Select Reset from the Upload tab while download is in progress. Wait for the reset operation to complete. Just after reset operation is complete , error will be displayed in the log .

Possible solution could be to disable the reset button while another operation is being performed.

@wbrunette wbrunette added Suitcase ODK-X Suitcase bug Something isn't working labels Mar 23, 2021
@wbrunette
Copy link
Member

@Shubhamr837 you are correct. This is a bug. Did you want to work on this or are you simply reporting it?

@Shubhamr837
Copy link
Author

@wbrunette Thanks. I would like to work on this. Could you please assign this to me .

@wbrunette
Copy link
Member

@Shubhamr837 I have assigned the issue to you. Thanks for finding and fixing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Suitcase ODK-X Suitcase
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants