-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IMP] Client side code cleaning and Python extension integration #85
Conversation
6845182
to
960903f
Compare
50ca72b
to
67034fc
Compare
7eeb0a3
to
f687c6d
Compare
842e676
to
2aa0c62
Compare
vscode/client/extension.ts
Outdated
} | ||
|
||
//trying to use the VScode python extension | ||
if (interpreter && global.IS_PYTHON_EXTENSION_READY !== false) { | ||
config ? pythonPath = interpreter.path[0] : pythonPath = null; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pythonPath = config ? interpreter.path[0] : null
@Louciole The extension crashes when starting as Disabled with the Python extension enabled |
I can't reproduce it (either in the debug or packaged version) did you do something special? |
Changes: - Remove pythonPath field from Config view - Integrate Python extension - Properly use async/await in the code. - Use of global.d.ts for Global variables. - Wait for LanguageClient to stop before starting it again - Queue Configuration change when LanguageClient is still stopping - Properly hide Crash notification test command in Production - outputChannel is now stored globally instead of being passed to all functions - Logging is now done through LanguageClient - Add a Bash shebang to build_package.sh Co-authored by Solan (sode)
… python extension Changes: - check if python extension is ready and save it in global - display python path in config when relevant - check and prepare the environment without python extension
The main goal of this commit is to be able not to set pythonPath when the extension is disabled
2aa0c62
to
9401ddd
Compare
/!\ there's probably still a bug on windows
if (_api) { | ||
return _api; | ||
} | ||
_api = await PythonExtension.api(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are we sure it will never become invalid?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We only use this Promise right after getting it and getting it each time we need it to be as close to the current configuration as we can be so there's no reason for it to be invalid in the current setup (but maybe I didn't understand the comment)
This PR aims to provide a first fix to many errors in the client code and acts as an intermediate patch until the client side is properly refactored.
The extension also now integrates VSCode's Python extension, which means the Language Server will now be launched with the Interpreter selected for that workspace.
Changes
Fixes