Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Mihai Iliescu to the contributors team #7233

Closed
lpalashevski opened this issue Dec 7, 2022 · 8 comments
Closed

Add Mihai Iliescu to the contributors team #7233

lpalashevski opened this issue Dec 7, 2022 · 8 comments
Assignees

Comments

@lpalashevski
Copy link
Contributor

lpalashevski commented Dec 7, 2022

As agreed via the maintainers channel, add Mihai Iliescu to contributors Team with read access across all repositories.

@lpalashevski
Copy link
Contributor Author

Added to CONTRIBUTORS.MD #7232

@planetf1
Copy link
Member

planetf1 commented Dec 7, 2022

  • For contributors we also need to invite/add the new joiner the the 'Egeria Contributors' 'team' defined at the ODPI level - this grants 'read' access to the repo which enables issue/PR assignment etc
  • The COnTRIBUTORS md file should contain email address if possible (I didn't do this last time!) as this is used by the Linux Foundation team to know where to send badges (checked monthly) - is Mihael ok with this? can you add @lpalashevski ?
  • Maintainers are similar, though they also need to be added to the maintainer mailing list

I've added Mihael to the relevant team

@lpalashevski
Copy link
Contributor Author

I am confused with the first point and the process here.. The purpose of this issue is to to request exactly what is mentioned :) am I missing something else?

About the email address and the badge, I will get back once he shares preferred email address (no public is visible in his gh profile).

Thanks.

@planetf1
Copy link
Member

planetf1 commented Dec 21, 2022

One of the benefits (to us, and them) of being a contributor, is that the they can be assigned issues prior to commenting, as well as PR reviews. For this to work they must have READ access to the repo (this differs from anon access). With our setup, this means they JOIN the odpi organization on github, and are added to the 'Egeria Contributors' github group. This is done by invite (can only direct add if they are already an org member).

Just adding to contributors.md does not do this

I just thought I should mention I - perhaps mistakenly, thought the issue was completed - so I took that action.

This is documented at https://egeria-project.org/guides/project-operations/?h=contributo#contributors under 'contributor approval process'.

We may benefit from a little checklist/issue template for adding contributors -- and maintainers (possibly the same form)

The badge is done by the LF team, who review the contributors.md regularly and look for email address, but I share your concern to make sure we have agreement for the address to be shared.

Suggest we discuss on a future call how we can make the process clearer and simpler

@planetf1
Copy link
Member

planetf1 commented Feb 3, 2023

@MihaiIliescu I have added you to the github contributors group. You should receive an email at the address listed in CONTRIBUTORS.md. This will increase your access to the project.

Have you received an email from the LF with your 'badge'. If not reply here and I'll chase up.

@MihaiIliescu
Copy link
Contributor

@planetf1 I have received the invitation and accepted it. Thank you!

@planetf1
Copy link
Member

planetf1 commented Feb 3, 2023

Super. Did you get sent a badge?

@MihaiIliescu
Copy link
Contributor

It was a bit low in the email inbox (5 jan) but I found it. Thank you!

@planetf1 planetf1 closed this as completed Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants