Delete s3 Objects and items related to an execution

[caviri]

These methods allows to delete all items related to an execution including s3 objects. It updates the digital twin document removing the reference to the execution document.

[sabinem]

@caviri just some small change request: the most important one: make providing the project-path optional.

[caviri]

Hello @sabinem, I addressed your suggestions. Would you make to take another look?

[sabinem]

@caviri I don't think you made the project-path optional. See screenshot:

[sabinem]

@caviri I approve now.

But I would still suggest that you improve a bit on the output of the command:

/app # odtp execution delete --execution-id 6683ed98b66b18232839f9d0
odtp/6683ed98b66b18232839f9d1/
odtp/6683ed98b66b18232839f9d1/odtp-output.zip

Could you please improve the output: I would rather expect a message here that the execution about what exactly has been deleted.

I left some comments in the code on this issue: the log statements write now to file for the execution commands, therefore you need to use print statements in the cli command for both exception and success cases.

Please remove the print from storage.py.

TODOs:

• remove print in storage.py
• add print in cli/execution.py and use log.exception instead of log.error since it gives you a traceback.

[sabinem]

I did not get this message in my tests. I got this instead:

odtp/6683af7d5923cfd2e73e613a/
odtp/6683af7d5923cfd2e73e613a/odtp-output.zip

[caviri]

I tested with the last rebase from develop and it works fine:

03/07/2024 10:42:20 AM - [storage:INFO] 140 storage.py deletePaths - Path 'odtp/66852a00d5b566c9b0c1b4cd' deleted from S3 bucket
03/07/2024 10:42:21 AM - [environment:INFO] 72 environment.py delete_folder - Folder deleted: /Users/carlosvivarrios/pro/ODTP/odtp-instance/dts/dt-example/dt-example/execution
03/07/2024 10:42:21 AM - [execution:INFO] 165 execution.py delete - SUCCESS: execution has been deleted
SUCCESS: execution has been deleted

[sabinem]

Add print statements in the cli command, since the log statement will only go to file

[caviri]

Thanks for the rewiew @sabinem, I see the logic now.

I'll follow this, but this should be change as In the future I would like to use print statements in the CLI to pipe CLI commands (Not implemented yet).

Ideally only log.X() should go to the log file, otherwise it's a bit confusing.