Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/improve cli and gui execution runs #176

Merged
merged 5 commits into from
Jul 1, 2024
Merged

Feat/improve cli and gui execution runs #176

merged 5 commits into from
Jul 1, 2024

Conversation

sabinem
Copy link
Contributor

@sabinem sabinem commented Jun 30, 2024 •
edited
Loading

This PR

CLI Features:

  • adds cli command odtp logs with argument --project-path to watch the logs
  • simplifies command odtp output to only have --project-path as an argument

GUI Festures:

  • simplify run page: disable and enable buttons depending on state
  • submit execution and the provide access to logs

@sabinem
feat(run.py): add log dir as volume on docker run
20161f0 
that way the log will be visible right away in the file system
if if the docker run command fails at some point
this seems to be essential for long running container and also
in cases of ephemeral containers when an error occurs
@sabinem
feat(cli/execution.py): add log streaming command
c75ae0d 
simplify the output and log streaming command: both just need the
project path
@sabinem
feat(dashboard/run page): simplify workflow and provide log access
f5f4ca5 
simplify the workflow and disable buttons after selection or when
proceesing is not ready

submit run and then offer a button to view log files
@sabinem
fix(logs in cli and gui): logs are seperated by steps
3eb6a23 
logs can only be offered in the gui and cli per step
@sabinem sabinem requested a review from caviri July 1, 2024 05:25
@sabinem
fix(cli logs): adapt error handling to os.system
762b914 
os.system does not throw an error, but keyboard interruptions
make sense here
@sabinem sabinem merged commit 6334971 into develop Jul 1, 2024
@sabinem sabinem deleted the feat/improve-cli-and-gui-execution-runs branch July 2, 2024 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caviri caviri caviri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sabinem @caviri