-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v0.4.0 #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
project forlder name is derived from the execution title on folder create there is always a new folder created in the users workspace so that the user will be able to easily run the selected execution
clone the component repo in such a way that the submodule is taken from the component repo commit: this needs to first check out the component commit and the fetch the submodule
clone the component repo in such a way that the submodule is taken from the component repo commit: this needs to first check out the component commit and the fetch the submodule
project forlder name is derived from the execution title on folder create there is always a new folder created in the users workspace so that the user will be able to easily run the selected execution
* fix(compose.prod.yml): removing app volume * typo(JSON_EDITOR): Correcting typo in variables * chore(compose.yml): Proposing compose.yml to avoid change in documentation with -f.
the variable had the wrong value
This PR fixes an env variable setting in the compose files
#157) feat(logs & output collections): Added missing collections in initial configuration
* fix(S3 Initiation): Fix for S3 initial setup * fix(exception): Exception applied on CLI and logging. * chore(cli/s3.py): adapt method to return value change * Erasing assignation. --------- Co-authored-by: sabinem <5292683+sabinem@users.noreply.github.com>
#155) fix(dependencies): Removing pyarrow and freezing numpy to <2 to avoid errors and warnings
that way the log will be visible right away in the file system if if the docker run command fails at some point this seems to be essential for long running container and also in cases of ephemeral containers when an error occurs
simplify the output and log streaming command: both just need the project path
simplify the workflow and disable buttons after selection or when proceesing is not ready submit run and then offer a button to view log files
logs can only be offered in the gui and cli per step
os.system does not throw an error, but keyboard interruptions make sense here
* feat(execution-timestamps) * feat(excecution & step): Added Creation/Update timestamp. Removed start/ending from creation. * feat(step timestamps logs): Added timestamps on orchestrator.
Change `docker run` command and add the logs directory as an extra volume, so that the logs will be visible right away and are also there for persistent component or in error runs of ephemeral compoents
This PR - depends on #175 to have accessible logs CLI Features: - adds cli command `odtp logs` with argument `--project-path` to watch the logs - simplifies command `odtp output` to only have `--project-path` as an argument GUI Festures: - simplify run page: disable and enable buttons depending on state - submit execution and the provide access to logs
* feat(docker): Avoid rebuilding images available * fix(attribute_name): self.container_names
Hello @sabinem, this is a hot-fix for a couple variables that I forgot to rename. I tested it with `dt-example` and works properly now.
- delete unused functions - log instead of print in the cli for some commands
* fix(dashboard): changed names of timestamp fields for execution adapt to changes in the mongodb * feat(dashboard executions): show start and end timestamps in table view of executions show also start and end timestamps --------- Co-authored-by: sabinem <5292683+sabinem@users.noreply.github.com>
rename command for streaming logs remove command for showing directory folder Co-authored-by: sabinem <5292683+sabinem@users.noreply.github.com>
* feat(logging): log commands to file to facilitate debugging * feat(cli execution): add both print and logs * chore(gitignore): add odtp.log to gitignore * fix(run.py): don't log secrets to file --------- Co-authored-by: sabinem <5292683+sabinem@users.noreply.github.com>
fix(dashboard run page): fix minor styling issue Co-authored-by: sabinem <5292683+sabinem@users.noreply.github.com>
* feat(delete): CLI method to delete execution s3 and project folder * feat(delete): CLI method to delete all MDB entries related to an execution * feat(execution delete): Keep folder * fix(project-path): Optional * fix(execution): Remove typo and non used method * fix(delete outputs): Fixed bug and added proejct_path as optional. * Using print statements. * chore(delete log): Logging only in debug * fix(DT Entry): Wrong email field was retrieved.
Co-authored-by: sabinem <5292683+sabinem@users.noreply.github.com>
sabinem
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v0.4.0 Release