Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input type on web interface is of type "text" when it would be better set to "url" #724

Closed
machawk1 opened this issue Jan 12, 2021 · 2 comments · Fixed by #725
Closed

Input type on web interface is of type "text" when it would be better set to "url" #724

machawk1 opened this issue Jan 12, 2021 · 2 comments · Fixed by #725

Comments

@machawk1
Copy link
Member

This affects the mobile keyboard displayed. Images below show a photo of a mobile device with a smudged screen exhibiting the two input type, which was required as many mobile devices will hide the keyboard when trying to take a screenshot. PR incoming.

type="text":
text

type="url"
url

@ibnesayeed
Copy link
Member

This will perhaps be a good change for now, but in the future if we decide to make it an omnibox to support free-form full-text search keywords or natural language date specifiers, the type will have to be changed back to text.

@machawk1
Copy link
Member Author

@ibnesayeed I agree and meant to mention this in the ticket. Currently, all this issue/PR does is help with accessibility but ultimately we will want to have something more freeform. I think that goal is far off and not-yet-described in any GitHub issue in this repo as far as I can tell.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants