Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ipwb util import alias. Closes #392. #420

Merged
merged 1 commit into from
Jul 8, 2018
Merged

Conversation

machawk1
Copy link
Member

@machawk1 machawk1 commented Jul 8, 2018

No description provided.

@machawk1 machawk1 requested a review from ibnesayeed July 8, 2018 03:04
Copy link
Member

@ibnesayeed ibnesayeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renaming it to a more sensible name is a good start, but more can be done to refactor utils (as discussed offline). This specific change LGTM!

@codecov
Copy link

codecov bot commented Jul 8, 2018

Codecov Report

Merging #420 into master will decrease coverage by 0.72%.
The diff coverage is 3.03%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #420      +/-   ##
==========================================
- Coverage   24.03%   23.31%   -0.73%     
==========================================
  Files           6        6              
  Lines        1111     1111              
  Branches      169      169              
==========================================
- Hits          267      259       -8     
- Misses        827      835       +8     
  Partials       17       17
Impacted Files Coverage Δ
ipwb/replay.py 13.22% <3.03%> (ø) ⬆️
ipwb/indexer.py 54.95% <0%> (-3.61%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d7d4e6...3344750. Read the comment docs.

@machawk1 machawk1 merged commit d44a613 into master Jul 8, 2018
@machawk1 machawk1 deleted the issue-392 branch July 8, 2018 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants