-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split date from time and position it before URI-R in listing #566
Conversation
Codecov Report
@@ Coverage Diff @@
## master #566 +/- ##
=======================================
Coverage 23.84% 23.84%
=======================================
Files 6 6
Lines 1191 1191
Branches 179 179
=======================================
Hits 284 284
Misses 887 887
Partials 20 20 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not a fan of the date-first styling, despite the consistent alignment of the URI. Perhaps this would be more convincing when we surface the titles in lieu of the URI-Rs but for now it is (subjectively) inferior to URI-R (date).
The primary reason of putting dates first was a good readable alignment (as you noted it). Also, the date is not linked, so it should not look as bad because the colored links will capture the gaze first. |
@ibnesayeed I disagree. Maybe it's the implicit precedence of putting the date before the URI-R, the switch to a longer (but more visually parse-able) date string (missing TZ, btw), or the square brackets over parens but I prefer the method displayed in current master over what this PR is offering despite its (mentioned) merits. Please add a little more to this PR per above and #178 (title) for approval. |
Parens were good when the date time was rendered after the URL (and title in the future), but if we want to place it up front, perhaps square brackets would make more sense. With dates and times split with delimiters, placing it after the link looks really ugly when half of it breaks into a new line. |
Non-wrapped entriesdatetime afterdatetime beforeWrapped entriesdatetime afterdatetime beforeI find the datetime before the URI more readable and well aligned in both the cases. That said, there is the possibility to force the datetime record never wrap, but it didn't look very good (to me) either. |
I see another merit in date-first in that it will always be displayed in the case of a long URI. We ought to adjust the text-overflow property of the URIs. Let's still get the titles working. Let me sleep on this PR. |
This PR changes URI listing from:
to