Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup logo source, add version with stroke for dark mode adaptation #690

Merged
merged 1 commit into from
Jul 9, 2020

Conversation

machawk1
Copy link
Member

@machawk1 machawk1 commented Jul 9, 2020

This PR updates the PSD by removing a stray pixel from the "planet" part of the image source and provides a relatively sized stroke to all elements to enhance the appearance when in dark mode.

This PR does not address the need to eventually use a vector format.

Closes #689

@machawk1 machawk1 requested a review from ibnesayeed July 9, 2020 15:30
@codecov
Copy link

codecov bot commented Jul 9, 2020

Codecov Report

Merging #690 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #690   +/-   ##
=======================================
  Coverage   29.26%   29.26%           
=======================================
  Files          10       10           
  Lines        1244     1244           
  Branches      184      184           
=======================================
  Hits          364      364           
  Misses        857      857           
  Partials       23       23           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98591c5...88c9e03. Read the comment docs.

@machawk1
Copy link
Member Author

machawk1 commented Jul 9, 2020

Still pending @ibnesayeed's review but:

  • Update ipwb/assets/logo.png so the white-stroked logo is also present in the replay web interface.

@ibnesayeed
Copy link
Member

ibnesayeed commented Jul 9, 2020

When adding in the assets, make sure you have it in the right size as we may not need a full-size image in the replay interface.

Copy link
Member

@ibnesayeed ibnesayeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@machawk1 machawk1 merged commit e4fd283 into master Jul 9, 2020
@machawk1 machawk1 deleted the logo-add-stroke branch July 9, 2020 15:51
@machawk1
Copy link
Member Author

machawk1 commented Jul 9, 2020

When adding in the assets, make sure you have it in the right size as we may not need a full-size image in the replay interface.

Discussion of this in #689. I think the task is beyond the scope of the issue, as the replay web interface does not yet adapt to dark mode. It should, but that will require more thought. Thanks for the quick approval, @ibnesayeed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

README logo is difficult to see in dark mode
2 participants