Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename vars to match a consistent, standard style. #713

Merged
merged 3 commits into from
Aug 26, 2020
Merged

Conversation

machawk1
Copy link
Member

No description provided.

Copy link
Member

@ibnesayeed ibnesayeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jObj can be changed to j_obj.

@codecov
Copy link

codecov bot commented Aug 26, 2020

Codecov Report

Merging #713 into master will not change coverage.
The diff coverage is 5.26%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #713   +/-   ##
=======================================
  Coverage   29.24%   29.24%           
=======================================
  Files          10       10           
  Lines        1248     1248           
  Branches      185      185           
=======================================
  Hits          365      365           
  Misses        860      860           
  Partials       23       23           
Impacted Files Coverage Δ
ipwb/__main__.py 0.00% <0.00%> (ø)
ipwb/replay.py 14.06% <3.12%> (ø)
ipwb/indexer.py 50.19% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a63039...a975ca3. Read the comment docs.

Co-authored-by: Sawood Alam <ibnesayeed@gmail.com>
@machawk1
Copy link
Member Author

Changed to something less cryptic in a975ca3, @ibnesayeed, though the semantics for this variable could be better.

Copy link
Member

@ibnesayeed ibnesayeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@machawk1 machawk1 merged commit 6e2be0f into master Aug 26, 2020
@machawk1 machawk1 deleted the naming_refactor branch August 26, 2020 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants