Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert some remaining string concatenations to f-strings #722

Merged
merged 1 commit into from
Oct 14, 2020

Conversation

machawk1
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Oct 14, 2020

Codecov Report

Merging #722 into master will not change coverage.
The diff coverage is 28.57%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #722   +/-   ##
=======================================
  Coverage   30.06%   30.06%           
=======================================
  Files          10       10           
  Lines        1264     1264           
  Branches      185      185           
=======================================
  Hits          380      380           
  Misses        861      861           
  Partials       23       23           
Impacted Files Coverage Δ
ipwb/replay.py 15.90% <0.00%> (ø)
ipwb/indexer.py 50.19% <40.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 649e486...e9dd873. Read the comment docs.

Copy link
Member

@ibnesayeed ibnesayeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@machawk1 machawk1 merged commit c1392a2 into master Oct 14, 2020
@machawk1 machawk1 deleted the more-f-strings branch October 14, 2020 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants