Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to latest release #4

Open
NobodyXu opened this issue Aug 25, 2023 · 7 comments
Open

Upgrade to latest release #4

NobodyXu opened this issue Aug 25, 2023 · 7 comments

Comments

@NobodyXu
Copy link
Contributor

NobodyXu commented Aug 25, 2023

In the latest release, we've refactored binstalk again and extract several crates out:

  • binstalk-registry for fetching crates from crates.io or any custom registry
  • binstalk-fetchers for actually fetching crates from release
  • binstalk-bins for installing bins
  • simple-git for cloning git repository directly
  • cargo-toml-workspace for loading manifest of any crate inside a workspace

With that, you could remove binstalk and disable features that are unused and further customize the APIs.

I also think it's good idea for such crates to be maintained in cargo-binstall repository since we would keep it up to date.

@oeb25
Copy link
Owner

oeb25 commented Aug 28, 2023

These changes sound great!

I also think it's good idea for such crates to be maintained in cargo-binstall repository since we would keep it up to date.

Which crates are you referring to here? If you are referring to moving binswap to cargo-binstall I would be happy to help in the process!

@NobodyXu
Copy link
Contributor Author

Which crates are you referring to here? If you are referring to moving binswap to cargo-binstall I would be happy to help in the process!

Yes, I'm referring to binswap, I personally think it makes sense for it to be maintained in cargo-binstall.

Also, I think cargo-bins need more maintainers for these crates and I welcome any PR and anybody who want to be one.

@passcod What's your thought on this?

@passcod
Copy link

passcod commented Aug 28, 2023

happy to

@NobodyXu
Copy link
Contributor Author

@oeb25 Can you submit a PR to cargo-binstall?
It will take quite some time since we would have to review it.
You could split it into multiple PRs.

@NobodyXu
Copy link
Contributor Author

I was a bit busy and almost forgot about this 😂

@NobodyXu
Copy link
Contributor Author

NobodyXu commented Jun 14, 2024

cc @oeb25 Are you still intere in upstreaming this into cargo-binstall repository?

I can give you maintainer role if you want.

@NobodyXu
Copy link
Contributor Author

cc @oeb25 friendly ping on this issue, I really believe this should be maintained in cargo-binstall repository to make sure it gets all the updates of binstalk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants