Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various minor issues when connecting networks #127

Closed
jnettels opened this issue Jun 16, 2023 · 0 comments · Fixed by #128
Closed

Various minor issues when connecting networks #127

jnettels opened this issue Jun 16, 2023 · 0 comments · Fixed by #128
Assignees
@jnettels

Comments

@jnettels
Copy link
Contributor

Under certain circumstances, various errors can occur in connect_points and geometry_operations.

  • weld_segments can remove lines unintentionally when two lines connect the same two points
  • If multiple lines connect the same two points in a network, eomof.solph will throw an error. (The error looks similar to the one mentioned in Issues with looped pipes #115, so they may be related)
  • The boundary' line connection method for creating the house connections could cause an error when the street line already touches the building

I have created a PR which attempts to solve the various issues I encountered.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jnettels jnettels

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix various errors in network connections oemof/DHNx
1 participant
@jnettels