Do not return unproven comments #3307
icecream17
started this conversation in
General
Replies: 1 comment 1 reply
-
This code is to perform pruning, which means it has not yet performed any search to "prove" that any value is in fact truth. For any value > VALUE_KNOWN_WIN, it is bad to assume such unproven results, therefore the above condition does what it says it does and the logic is correct. |
Beta Was this translation helpful? Give feedback.
1 reply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Stockfish/src/search.cpp
Lines 832 to 837 in 77eeea4
I'm a bit confused about this comment, it looks like the opposite thing is happening.
The code disallows proven wins right???
It returns positive eval, and for example VALUE_MATE > VALUE_KNOWN_WIN... so I don't know what it could possibly be.
Beta Was this translation helpful? Give feedback.
All reactions