Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vary time use with eval. #5138

Closed
wants to merge 1 commit into from
Closed

Conversation

xoto10
Copy link
Contributor

@xoto10 xoto10 commented Mar 27, 2024

Adjust time use depending on the current eval.

Passed STC :
LLR: 2.94 (-2.94,2.94) <0.00,2.00>
Total: 101696 W: 26651 L: 26238 D: 48807
Ptnml(0-2): 400, 11602, 26459, 11959, 428
https://tests.stockfishchess.org/tests/live_elo/660187a50ec64f0526c557f6

Passed LTC :
LLR: 2.94 (-2.94,2.94) <0.50,2.50>
Total: 60648 W: 15550 L: 15187 D: 29911
Ptnml(0-2): 40, 6356, 17171, 6715, 42
https://tests.stockfishchess.org/tests/live_elo/660298ed0ec64f0526c566d0

Values were found using two tunes with the final values taken from the ltc tune after 62k games :
stc - https://tests.stockfishchess.org/tests/view/65fb526b0ec64f0526c50694
ltc - https://tests.stockfishchess.org/tests/view/65fd36e60ec64f0526c5214b

Ideas for future work;

  • tune these values with the other TM adjustments
  • try narrower bands
  • calculate adjustment for exact eval by interpolation

Bench 2103324

@xoto10
Copy link
Contributor Author

xoto10 commented Mar 27, 2024

Notes:

  • I changed the variable name from the one used in the tests and made evalLevel[] a static constexpr
  • I ran clang-format and pushed again

@Disservin
Copy link
Member

evalLevel should be named in PascalCase :)

@xoto10
Copy link
Contributor Author

xoto10 commented Mar 27, 2024

evalLevel case updated

@mstembera
Copy link
Contributor

mstembera commented Mar 28, 2024

It's surprising that the values in EvalLevel[] don't seem to have a trend predictable from bestValue.

@xoto10
Copy link
Contributor Author

xoto10 commented Mar 28, 2024

Yes. Maybe it could be approximated, we could try smaller divisions to get a better idea of the shape. Seems to be neutral when eval ~= 0, lower when slightly away from zero and then swinging to higher time use when the position is more critical (roughly eval > 120cp).
I expected it to be symmetrical around 0, but it looks like it isn't.

@xoto10
Copy link
Contributor Author

xoto10 commented Mar 29, 2024

I screwed up there, updating the branch with the values after the LTC tune finished, I've reverted it back so that this PR has the values which passed stc and ltc. Currently testing the 100k values using the timetotal3c branch.

@vondele vondele added 🚀 gainer Gains elo no-bench-change to be merged Will be merged shortly labels Mar 29, 2024
@vondele vondele closed this in e636f73 Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚀 gainer Gains elo no-bench-change to be merged Will be merged shortly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants