Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

export validators from addon namespace #152

Conversation

luxzeitlos
Copy link
Contributor

move the validators to the addon namespace an just reflect them in the app namespace for better extensibility.

*/

import Ember from 'ember';
import Base from 'ember-cp-validations/validators/base';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change all of these to:

import Base from './validators/base';

@luxzeitlos
Copy link
Contributor Author

Do you mean ./base?

import Base from './base';

I can do this but I don't think full path is bad.

@offirgolan
Copy link
Collaborator

Yes

On Monday, March 28, 2016, Lukas Kohler notifications@github.com wrote:

Do you mean ./base?

import Base from './base';

I can do this but I don't think full path is bad.


You are receiving this because you commented.
Reply to this email directly or view it on GitHub
#152 (comment)

Thanks,
Offir Golan

@luxzeitlos
Copy link
Contributor Author

Well, I've done that with cff938b

@offirgolan
Copy link
Collaborator

👍 Thank you 😸

@offirgolan offirgolan merged commit 4bbec83 into adopted-ember-addons:master Mar 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants