Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flutter_carplay does not work with obfuscation #28

Open
vanlooverenkoen opened this issue Sep 19, 2022 · 1 comment · May be fixed by #29
Open

flutter_carplay does not work with obfuscation #28

vanlooverenkoen opened this issue Sep 19, 2022 · 1 comment · May be fixed by #29

Comments

@vanlooverenkoen
Copy link

When building your app with obfuscation the app crashes when starting carplay.

This is probably because the methodchannels are parsed using tostring enum's I will double check this and create a new pull request.
vanlooverenkoen added a commit to icapps/flutter_carplay that referenced this issue Sep 19, 2022
@vanlooverenkoen
oguzhnatly#28: Added support for obfuscation
4e1e67b
@vanlooverenkoen vanlooverenkoen linked a pull request Sep 19, 2022 that will close this issue
Open
vanlooverenkoen added a commit to icapps/flutter_carplay that referenced this issue Sep 19, 2022
@vanlooverenkoen
Merge branch 'feature/oguzhnatly#28-obfuscation' into combined
222854c
@vanlooverenkoen
Copy link
Author

runtimeType.toString() should never be used.
In this case you are expecting that the toString will generate a string that matches your native side. That does not work when working with obfuscation.

vanlooverenkoen added a commit to icapps/flutter_carplay that referenced this issue Sep 19, 2022
@vanlooverenkoen
Merge branch 'feature/oguzhnatly#28-obfuscation' into combined
1eae162
szeidner added a commit to szeidner/flutter_carplay that referenced this issue Nov 30, 2022
@szeidner
Merge pull request #3 from icapps/feature/oguzhnatly#28-obfuscation
1d2c003 
Feature/oguzhnatly#28 obfuscation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature/#28 obfuscation icapps/flutter_carplay
1 participant
@vanlooverenkoen