Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistency in page design- normal and critical log update #7351

Closed
3 tasks done
aparnacoronasafe opened this issue Mar 6, 2024 · 14 comments
Closed
3 tasks done

Inconsistency in page design- normal and critical log update #7351

aparnacoronasafe opened this issue Mar 6, 2024 · 14 comments
Assignees
Labels

Comments

@aparnacoronasafe
Copy link
Member

aparnacoronasafe commented Mar 6, 2024

Is your feature request related to a problem? Please describe.
Critical care log update- https://care.coronasafe.in/facility/0c95c7f0-e1d2-4aff-83fa-933cef60d3a8/patient/7e8fc20f-02da-47f7-8c33-f2d8c7e52dd8/consultation/cb44a173-6fe2-452f-b2d1-6c6e2695411e/daily_rounds/2da792c7-7ff8-4b8f-8e68-1397b7848597
Normal log update: https://care.coronasafe.in/facility/0c95c7f0-e1d2-4aff-83fa-933cef60d3a8/patient/7e8fc20f-02da-47f7-8c33-f2d8c7e52dd8/consultation/cb44a173-6fe2-452f-b2d1-6c6e2695411e/daily-rounds/57ba21bd-e024-4ab0-9362-a9af35f75acc

The design of the pages is very different. Make the design consistent.

Action Items

  • Migrate the Critical Care sections list page to Typescript #7855
  • Identify the reusable components present in the Critical Care rescript files. (eg: Slider, Pain Scale Editor, Pressure Sore Editor, etc.) and convert those reusable components to typescript components.
  • Once the above is completed, move all the remaining critical care pages to typescript. This could be done section by section (individual PRs).
@hrit2773
Copy link
Contributor

hrit2773 commented Mar 6, 2024

@aparnacoronasafe what account credentials should we use to reproduce the issue I would like to work on this issue plz assign me

@Ashesh3
Copy link
Member

Ashesh3 commented Mar 6, 2024

**hrit2773 ** commented Mar 6, 2024

@hrit2773

- username: devdistrictadmin
  password: Coronasafe@123

@hrit2773
Copy link
Contributor

hrit2773 commented Mar 10, 2024

@rithviknishad I have worked on it and matched the UI of critical and abnormal with stable log update can I make a pull request now. You added the tag discussion required right any reasons?

@hrit2773 hrit2773 removed their assignment Mar 13, 2024
@Anish-Parkhi
Copy link

If this issue is not assigned to anyone then I can work on this @aparnacoronasafe ?

@hrit2773
Copy link
Contributor

@Anish-Parkhi this has discussion required tag so that's why I didn't make any PR

@rithviknishad rithviknishad moved this from Triage to Up Next in Care Mar 18, 2024
@rithviknishad
Copy link
Member

@hrit2773 @Anish-Parkhi I've updated the main comment to clarify what needs to be done. It'd be a two-part PR as the latter would require redesigning and UI approval to move forward. A mockup design can be shared on how the new UI looks and needs approval.

@Anish-Parkhi
Copy link

@rithviknishad I have reviewed both the pages and I have figured out reusable components in both pages, should I make a mockup in figma and share it with you, also which page's UI should I refer ? the critical care log or normal log ?

@rithviknishad
Copy link
Member

@Anish-Parkhi the components are already present. Just that those rescript components need to be rewritten in typescript.

A mockup is only required for the second PR.

@Anish-Parkhi
Copy link

@rithviknishad okay so I will rewrite the components in typescript and make first PR then I will start with the second PR

Copy link

github-actions bot commented Apr 2, 2024

Hi, @gigincg, @nihal467, @khavinshankar, @mathew-alex, @aparnacoronasafe, This issue has been automatically marked as stale because it has not had any recent activity.

Copy link

sentry-io bot commented Apr 21, 2024

Sentry Issue: CARE-FE-3BD

@rithviknishad
Copy link
Member

@Anish-Parkhi unassigning due to no activity

@AshrafMd-1
Copy link
Contributor

@rithviknishad can you assign me this issue

@rithviknishad
Copy link
Member

Closing as further changes required scoped in issue #8115

@rithviknishad rithviknishad closed this as not planned Won't fix, can't repro, duplicate, stale Aug 21, 2024
@github-project-automation github-project-automation bot moved this from Up Next to Done in Care Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

No branches or pull requests

6 participants