Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify bed creation notification to show proper action related notification #8627

Closed
2 tasks
nihal467 opened this issue Sep 25, 2024 · 4 comments · Fixed by #8632
Closed
2 tasks

Modify bed creation notification to show proper action related notification #8627

nihal467 opened this issue Sep 25, 2024 · 4 comments · Fixed by #8632
Assignees

Comments

@nihal467
Copy link
Member

Describe the bug

When we are creating a single bed or multiple bed, all the time, the notification shown is " Bed(s) Created successfully "

To Reproduce
Steps to reproduce the behavior:

  1. Open any facility card
  2. Open manage facility and click on location management
  3. Create a new location and click on the manage bed button
  4. add a single bed only
  5. see the error

Expected behavior

  • If a single bed is created, show the notification: "Bed created successfully."
  • If multiple beds are created, show the notification: "Beds created successfully."

Screenshots

image

@AdityaJ2305
Copy link
Contributor

Hey @nihal467, could you please assign me to this issue? Thanks!

@AdityaJ2305
Copy link
Contributor

Hi @rithviknishad, I just saw your comment. I wanted to bring up that this has happened to me twice now—where someone else submitted a PR for an issue I was already assigned to, without being assigned themselves or checking with the maintainer first.

@rithviknishad
Copy link
Member

No worries, we'll get your PR approved once the review changes requested are solved.

@syedfardeenjeelani
Copy link
Contributor

Hi @rithviknishad ,

Apologies for the confusion! When I started working on the issue, no one was assigned to it. I wasn’t familiar with the guidelines at the time, but I’ll make sure to comment and check before taking on any issue going forward. Sorry again for any inconvenience caused, @AdityaJ2305 .

Additionally, I had raised another PR for issue #8583 before this. Thank you for understanding!

@github-project-automation github-project-automation bot moved this from Review required to Done in Care Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
5 participants