Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Logging): Updates logging to allow for tracking processing time #522

Merged
merged 1 commit into from
Mar 15, 2024

Conversation

timnolte
Copy link
Collaborator

All Submissions:

Changes proposed in this Pull Request:

  • Supports Server response lag when using openid-connect-generic #516
  • Updates the logging to also allow for tracking processing time of actions.
  • Refactors logging to allow for unit testing.
  • Adds unit tests for logging.
  • Updates Composer dependencies to the latest versions.
  • Changes GitHub Actions unit testing to reduce failures.
  • Updates Dev Container to be less noisy and remove false positive errors during startup.

How to test the changes in this Pull Request:

Dev Container

  1. Startup the Dev Container.
  2. Review startup output.
  3. Note that there shouldn't be red error notices for items that are expected to happen during startup.

Logging Updates

  1. Turn on Logging.
  2. Observe new logging table output that includes processing time on some actions.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?

Changelog entry

Enter a summary of all changes on this Pull Request. This will appear in the changelog if accepted.

  • Updates the logging to also allow for tracking processing time of actions.
  • Updates Composer dependencies to the latest versions.
  • Updates Dev Container to be less noisy and remove false positive errors during startup.

- Supports #516
- Updates the logging to also allow for tracking processing time of actions.
- Refactors logging to allow for unit testing.
- Adds unit tests for logging.
- Updates Composer dependencies to the latest versions.
- Changes GitHub Actions unit testing to reduce failures.
- Updates Dev Container to be less noisy and remove false positive errors during startup.
@timnolte timnolte linked an issue Mar 15, 2024 that may be closed by this pull request
Copy link

Coverage report for commit: 57c08c4
File: clover.xml

Cover ┌─────────────────────────┐ Freq.
   0% │ ███████████████████████ │ 75.0%
  10% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  20% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  30% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  40% │ ████░░░░░░░░░░░░░░░░░░░ │ 12.5%
  50% │ ████░░░░░░░░░░░░░░░░░░░ │ 12.5%
  60% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  70% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  80% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  90% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
 100% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
      └─────────────────────────┘
 *Legend:* █ = Current Distribution 
Summary - Lines: 3.51% | Methods: 5.21%
FilesLinesMethodsBranches
/workspaces/openid-connect-generic/includes
   functions.php-100.00%100.00%
   openid-connect-generic-client-wrapper.php--100.00%
   openid-connect-generic-client.php--100.00%
   openid-connect-generic-login-form.php--100.00%
   openid-connect-generic-option-logger.php37.80%44.44%100.00%
   openid-connect-generic-option-settings.php47.37%12.50%100.00%
   openid-connect-generic-settings-page.php--100.00%
/workspaces/openid-connect-generic
   openid-connect-generic.php1.77%-100.00%

🤖 comment via lucassabreu/comment-coverage-clover

@timnolte timnolte merged commit c59faf0 into develop Mar 15, 2024
8 checks passed
@timnolte timnolte deleted the feature/516-server-response-monitoring branch March 15, 2024 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Server response lag when using openid-connect-generic
1 participant