Add Support for nonce Attribute

[khelil]

Hi 🖖

I'm trying to configure the plugin with France Connect, the french government SSO.

After configuration and connection try, i've got this error :
{"status":"fail","message":"The following fields are missing or empty : nonce"}

I've looked for previous issues and looks like the nonce param is not set in the plugin as it is optional for an OpenId flow.
The problem is that nonce param is requested from France Connect.

Is it planned to add this to the plugin ?

Thx

[timnolte]

@khelil hmm, I'll have to do some digging into this. I have not found an IDP at this point that has required that.

[khelil]

thanks for you answer @timnolte

France Connect is the french gov IDP. It's used to access sensitive and personal datas so i suppose that why they're requesting the nonce param.

If it's not planned from your side, i will try to implement it and will push a PR if you're interested...

[khelil]

Ok got this working, won't push a PR as France Connect is too specific and i had to tweaks some functions to make it work.

If someone need, the WordPress France Connect plugin is available here :
https://github.com/Partikuls/france-connect-wordpress

[timnolte]

@khelil hmm, I'm curious what you all had to change as the plugin should work for any OpenID Connect compliant IDP. Was there more than just the nonce?

[khelil]

Yes @timnolte, here are the changes:

• addition of nonce, same logic as state param for creation
• nonce is stored in state_values array in same transient
• for verification France Connect IDP sends nonce in response of request to endpoint /token
• if nonce or state have been modified, user needs to be disconnected from the IDP, I therefore had to modify the authentication_request_callback() function and state validation logic to add redirection to IDP in both case
• lastly in request_authentication_token() function, had to make a GET call instead of POST

[timnolte]

@khelil hmm, that last point of having to change to a GET call seems wrong. 🤔

[timnolte]

@khelil the OpenId Connect specs clearly state that token requests must be sent via POST.

https://openid.net/specs/openid-connect-core-1_0.html#TokenRequest

[timnolte]

To a degree I believe that the nonce support should be added in the same way that acr support was added. The exception being that this should be a boolean plugin setting.

#389

[khelil]

@timnolte agree, more secure is alway better ;)