Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request perms at runtime to connect to net #1

Closed
taoeffect opened this issue Jun 26, 2022 · 0 comments · Fixed by #10
Closed

Request perms at runtime to connect to net #1

taoeffect opened this issue Jun 26, 2022 · 0 comments · Fixed by #10

Comments

@taoeffect
Copy link
Member

taoeffect commented Jun 26, 2022

Problem

Need to make sure contract code doesn't try anything funny.

Solution

https://deno.land/manual/runtime/permission_apis

Consider also doing the same for write permissions when <url-or-dir> is a directory that's outside of .

May want to allow net in general case (e.g. to make things like deno deploy smoother), and restrict it when using any of the contract-related commands.

See also comment in src/upload.ts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant