-
-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Figure out hash situation #1604
Comments
How about something like:
Where the hash consists of:
Thoughts @corrideat @snowteamer? |
OTOH, we already have code in Being able to double-click hashes is nice. Plus, we can identify hashes in the database by their prefix. It's just not human-readable, but maybe that isn't a big deal. |
Agreed on being able to double-click hashes is nice. In our case I'm not sure hash human-readability is a big deal either. We're not using many different hash formats anyway. |
@snowteamer Yeah, agreed, we can stick with the current format. Question about that: do the changes that you made in I'd like to make sure that information is included in the hash. |
@taoeffect IIRC, these changes result in hashes including binary-to-text encoding format (i.e. that |
@snowteamer how do we add the fact that JSON was used to the hash? |
Hash situation figured out! Many thanks to @snowteamer for helping implement it in |
Problem
There are several problems with the way we're hashing:
'blake2b-256'
not'blake2b-32'
), resulting in the wrong hash prefix2DrjgbEipReKVH8QSmAxE586CiaCtyh1GVRTaPf5d5aqCcZowc
we need hashes likez2DrjgbEipReKVH8QSmAxE586CiaCtyh1GVRTaPf5d5aqCcZowc
for compat with thechel
command as it currently existsSolution
Explore how hashes are identified in other systems. For example, SSB uses a human-readable postfix instead of a prefix.
We want something like that. There are some considerations with SSB's approach:
.
as a separator also makes double-clicking an issue, but if we use base58 for everything then I'm not sure a separator is possible.The text was updated successfully, but these errors were encountered: