Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard: only show history if it exists #2269

Closed
dotmacro opened this issue Jul 29, 2024 · 0 comments · Fixed by #2297
Closed

Dashboard: only show history if it exists #2269

dotmacro opened this issue Jul 29, 2024 · 0 comments · Fixed by #2297

Comments

@dotmacro
Copy link
Member

dotmacro commented Jul 29, 2024

Problem

Note: This is very similar to issue #2163

On testing, as soon as the group is created, the dashboard "support %" and "todo %" tabs both correctly indicate that there is no history yet. (This was not tested on live.)

noHistory-testingCorrect

However, on live and testing, as soon as the first distribution period starts, the dashboard "support %" and "todo %" tabs both show 0% for the period preceding the first distribution, even though that period didn't exist -- meaning no users were instructed to send payments, nor could they have marked payments as sent in the app.

noHistory--testingIncorrectSupport
noHistory-testingIncorrectTodo

Solution

Only show history when history exists. The first distribution period should be the first period tracked on the Support, TODO, and Activity tabs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants