Initial review

[amercader]

Great work @avdata99, some things I found worth fixing before an initial release

• Form styling, is this supposed to look like this? (I'm using a vanilla CKAN):
  

• Banner styling; this also doesn't look good on standard CKAN:
  

• If dates are mandatory they should be a validation step to check if there were filled. Now you get an Internal server error. Alternatively, not entering any date means that the announcement is shown immediately and indefinitely (until a sysadmin deletes it)

• Small typo here:
  

• People will most likely want to override the announcement template so move it to a separate snippet in templates/announcements/announcement.html or something and then include that from templates/header.html to make it easier

• Let's support Markdown styling by adding h.render_markdown(announcement.message) to the snippet

• On the delete popup: "Are you sure you want to delete this announcement?", Scope -> Time Period

Also as this is a new extension let's run Black and use it going forward

[avdata99]

Typo fixed

[avdata99]

Create separate snippet for announcements here

[avdata99]

Markdown allowed here

[avdata99]

Updated delete pop up here

[avdata99]

Flake8 added here
Should we also add black?

[amercader]

Yes, let's use black @avdata99
Send a PR with further changes so they are easier to review