-
-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unchecked _max_tb causing TypeError: '<=' not supported between instances of 'int' and 'nonetype' #137
Comments
Nice catch. It seems like it, looking at the code, since _max_tb defaults to None in this file. I think the fix may be to set the default value to 1 instead of None, since it more matches the current implementation. |
Haha, I don't know if I'm using the code in an unexpected way then, but for me that was still initialized to None and causing issues 😄 |
Do you have a toy example that causes the failure? |
I'll fix it, but I'd like to have a way to reproduce the problem |
I'm going on holiday tomorrow for a week, but once I'm back home I'll try to come up with some code to reproduce the issue (just so you know why my next comment will take a while). |
I've got a fix, I'll push in place soon |
Fixed with 2.2.2 |
There seems to be a missing check in this line causing a TypeError inside
log_failure
.Shouldn't this be checking for
_max_tb
as well before the <=, like:The text was updated successfully, but these errors were encountered: