Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Files should be submitted even if importing fails #367

Open
albertkx opened this issue Mar 5, 2019 · 2 comments
Open

Files should be submitted even if importing fails #367

albertkx opened this issue Mar 5, 2019 · 2 comments
Assignees

Comments

@albertkx
Copy link

albertkx commented Mar 5, 2019

Some students have run into issues where they have top-level syntax errors, i.e. indentation issues, that prevent their assignment file from being imported. This also prevents ok client from submitting the file.

image

We should have ok client submit the assignment file to okpy even if top-level syntax errors cause local testing to error, so we have a submission which we can regrade.

@ja5087
Copy link
Contributor

ja5087 commented Mar 22, 2019

Will look into this

@ja5087 ja5087 self-assigned this Mar 22, 2019
@ja5087
Copy link
Contributor

ja5087 commented Apr 1, 2019

The issue is due to how the client imports all dependencies listed in the config.ok file to build the Assignments object, then errors since the test file cannot be loaded as a module. I will look into writing it so the code only loads the tests as the doctests protocol is run so other protocols (namely, backup) can still run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants