From ebafd5cb13afae7c8bf365782264c248b8345960 Mon Sep 17 00:00:00 2001
From: Edbury Enegren <36284167+edburyenegren-okta@users.noreply.github.com>
Date: Tue, 24 Jan 2023 12:17:52 -0800
Subject: [PATCH] feat(odyssey-react-mui)!: make rem-base themeable, add
 element styles to ScopedCssBaseline

BREAKING CHANGE: remove `kbd` variant from Typography component
---
 .../src/theme/components.tsx                  | 102 +++++++++++++-----
 .../src/theme/typography.types.ts             |   3 -
 2 files changed, 78 insertions(+), 27 deletions(-)

diff --git a/packages/odyssey-react-mui/src/theme/components.tsx b/packages/odyssey-react-mui/src/theme/components.tsx
index c5843dc85f..3e1b15a212 100644
--- a/packages/odyssey-react-mui/src/theme/components.tsx
+++ b/packages/odyssey-react-mui/src/theme/components.tsx
@@ -355,13 +355,6 @@ export const components: ThemeOptions["components"] = {
       disableRipple: true,
     },
   },
-  MuiCssBaseline: {
-    styleOverrides: {
-      boxSizing: "border-box",
-      fontFeatureSettings: "'lnum','pnum'",
-      fontVariant: "normal",
-    },
-  },
   MuiCheckbox: {
     defaultProps: {
       size: "small",
@@ -510,6 +503,84 @@ export const components: ThemeOptions["components"] = {
       }),
     },
   },
+  MuiCssBaseline: {
+    styleOverrides: (themeParam) => `
+      html {
+        font-size: calc((${themeParam.typography.fontSize} / 16) * 100%);
+      }
+    `,
+  },
+  MuiScopedCssBaseline: {
+    styleOverrides: {
+      root: ({ theme }) => ({
+        kbd: {
+          display: "inline-block",
+          minWidth: `calc(${theme.typography.subtitle1.fontSize} * ${theme.typography.h5.lineHeight})`,
+          borderStyle: theme.mixins.borderStyle,
+          borderWidth: theme.mixins.borderWidth,
+          borderRadius: theme.mixins.borderRadius,
+          borderColor: theme.palette.grey[200],
+          backgroundColor: theme.palette.grey[50],
+          padding: `calc(${theme.spacing(1)} / 2) ${theme.spacing(1)}`,
+          fontSize: theme.typography.subtitle1.fontSize,
+          fontWeight: theme.typography.fontWeightRegular,
+          lineHeight: theme.typography.h5.lineHeight,
+          boxShadow: `0 1px 1px 0 hsla(240, 6%, 12%, 0.05)`,
+        },
+
+        p: {
+          maxWidth: theme.mixins.maxWidth,
+          marginBlockStart: 0,
+          marginBlockEnd: theme.spacing(4),
+
+          "&:last-child": {
+            marginBlockEnd: 0,
+          },
+        },
+
+        "ul, ol": {
+          maxWidth: theme.mixins.maxWidth,
+          marginBlockStart: 0,
+          marginBlockEnd: theme.spacing(4),
+          // Unique padding to get desire appearance with "outside" position
+          paddingInlineStart: "2ch",
+
+          ol: {
+            listStyleType: "lower-alpha",
+
+            ol: {
+              listStyleType: "lower-roman",
+            },
+          },
+
+          "&:last-child": {
+            marginBlockEnd: 0,
+          },
+        },
+
+        li: {
+          marginBlockEnd: theme.spacing(2),
+          paddingInlineStart: theme.spacing(1),
+
+          "ul, ol": {
+            marginBlockStart: theme.spacing(2),
+            marginInlineStart: `calc(${theme.spacing(6)} - 2ch)`,
+          },
+        },
+
+        samp: {
+          padding: "0 0.5ch",
+          backgroundColor: theme.palette.grey[50],
+          boxShadow: `0 1px 0 ${theme.palette.grey[50]}`,
+          fontSize: theme.typography.body1.fontSize,
+
+          kbd: {
+            background: theme.palette.common.white,
+          },
+        },
+      }),
+    },
+  },
   MuiDialog: {
     defaultProps: {
       scroll: "paper",
@@ -1451,7 +1522,6 @@ export const components: ThemeOptions["components"] = {
         subtitle1: "p",
         body1: "p",
         inherit: "p",
-        kbd: "kbd",
         legend: "legend",
       },
     },
@@ -1459,22 +1529,6 @@ export const components: ThemeOptions["components"] = {
       paragraph: ({ theme }) => ({
         marginBottom: theme.spacing(4),
       }),
-      root: ({ theme, ownerState }) => ({
-        ...(ownerState.variant === "kbd" && {
-          display: "inline-block",
-          minWidth: `calc(${theme.typography.subtitle1.fontSize} * ${theme.typography.h5.lineHeight})`,
-          borderStyle: theme.mixins.borderStyle,
-          borderWidth: theme.mixins.borderWidth,
-          borderRadius: theme.mixins.borderRadius,
-          borderColor: theme.palette.grey[200],
-          backgroundColor: theme.palette.grey[50],
-          padding: `calc(${theme.spacing(1)} / 2) ${theme.spacing(1)}`,
-          fontSize: theme.typography.subtitle1.fontSize,
-          fontWeight: theme.typography.fontWeightRegular,
-          lineHeight: theme.typography.h5.lineHeight,
-          boxShadow: `0 1px 1px 0 hsla(240, 6%, 12%, 0.05)`,
-        }),
-      }),
     },
   },
 };
diff --git a/packages/odyssey-react-mui/src/theme/typography.types.ts b/packages/odyssey-react-mui/src/theme/typography.types.ts
index 70f9e18265..1a7fb4a975 100644
--- a/packages/odyssey-react-mui/src/theme/typography.types.ts
+++ b/packages/odyssey-react-mui/src/theme/typography.types.ts
@@ -14,12 +14,10 @@ import { CSSProperties } from "react";
 
 declare module "@mui/material/styles" {
   interface TypographyVariants {
-    kbd: CSSProperties;
     legend: CSSProperties;
     ui: CSSProperties;
   }
   interface TypographyVariantsOptions {
-    kbd?: CSSProperties;
     legend?: CSSProperties;
     ui: CSSProperties;
   }
@@ -30,7 +28,6 @@ declare module "@mui/material/Typography" {
     body1: true; // Design may refer to this as "body"
     body2: false;
     button: false;
-    kbd: true;
     legend: true;
     overline: false;
     subtitle1: true; // Design may refer to this as "caption"