fix: Icon generation now using newest version of SVGR and SVGO #1755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinGhadyani-Okta
requested review from
a team,
ganeshsomasundaram-okta and
kamronbatmanghelich-okta
as code owners
|
@KevinGhadyani-Okta this updates the build but not the Icons themselves, correct? |
|
@edburyenegren-okta If we had any icons that were updated in that Figma folder, then it does update them. But I didn't make changes to that folder, so everything should be the same. I did a look-over, and they looked fine to me. The |
|
Weird that we're getting more compression than before. I think that's 🆗 for now, and we can get a complete design review when @jordankoschei-okta updates us with the new icon set. As long as we're okay doing some additional config tweaking if design wants less path compression, we're good to merge! |
edburyenegren-okta
approved these changes
Apr 25, 2023
jordankoschei-okta
pushed a commit
that referenced
this pull request
Apr 26, 2023
* fix: upgraded SVGR and converted to TS to address API change * fix: upgraded odyssey-svgr to TypeScript * fix: refactored odyssey-icons package to TypeScript * fix: reverted to previous config in odyssey-icons * fix: updated location and filename for svgo.config.ts * fix: updated SVGR config to no longer build the icons/index.ts itself * fix: updated icons per the latest SVGR v7 * docs(odyssey-storybook): added docs for how to generate new icons
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Before, we had SVGR on v5. When the upgrade to v7 occurred, all our configs and settings were broken, but we didn't know because we hadn't generated icons in a while.
I converted the SVGR and SVGO libraries to use TypeScript so we'll get TS failures in the future if an upgrade causes icon generation to break.
I also had to change how we generated the index file. Templating it is no longer possible, so we have to maintain that file by hand ;(.