Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't seem to work with knex@2.0.0 #35

Closed
cerinoligutom opened this issue May 23, 2022 · 7 comments
Closed

Doesn't seem to work with knex@2.0.0 #35

cerinoligutom opened this issue May 23, 2022 · 7 comments

Comments

@cerinoligutom
Copy link

image

Have a users table with a createdAt field and I'm sorting using that field. Code:

await UserModel.query().orderBy('asc', 'createdAt').limit(10).nextCursorPage(myCursor);

Code works fine on knex@0.95.14 though. I think v1 is also broken as well since I've had a similar issue on one of my repo cerinoligutom/GraphQL-Starter#27 (comment) where downgrading to 0.95.14 fixed the issue. I guess knex changed an underlying API that broke this plugin?

@olavim
Copy link
Owner

olavim commented May 23, 2022

Thanks for reporting. I'll try to get this fixed ASAP.

@olavim
Copy link
Owner

olavim commented May 24, 2022

What knex and objection versions are you using? And what database? I tested the following combinations with sqlite:

objection knex status
2.2.18 knex@0.95.14
2.2.18 knex@1.0.7
2.2.18 knex@2.0.0
3.0.1 knex@0.95.14
3.0.1 knex@1.0.7
3.0.1 knex@2.0.0

Note: knex@1.0.7 failed because it depends on an sqlite3 package that no longer exists.

@cerinoligutom
Copy link
Author

knex@2.0.0, objection@3.0.1, postgres:13

@olavim
Copy link
Owner

olavim commented May 24, 2022

Can you check if version 1.2.6-alpha.0 fixes the issue for you?

@cerinoligutom
Copy link
Author

Hey @olavim, works great! I don't get the error anymore 🎉

@olavim
Copy link
Owner

olavim commented May 24, 2022

Great! Fixed in v1.2.6.

@olavim olavim closed this as completed May 24, 2022
@cerinoligutom
Copy link
Author

Thank you for the quick fix! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants