-
Notifications
You must be signed in to change notification settings - Fork 864
Mobile (hamburger) navigation not responding. #951
Comments
In your example there aren't any mobile menu items in the HTML. Can you post a screenshot of Menu->Manage Locations tab in WP? |
I'm having the same issue and I haven't solved it yet. Glad if this issue could be fixed. |
Hi Guys, chiming in with a question. Can you guys inspect the page in Chrome in mobile mode and check inspector if you are seeing a JS error? |
No JS error on my site, when I inspect it in mobile mode in Chrome |
No errors on my end either. |
OK. I'm seeing a JS error on the test case @gbrl posted but it may not be related. I can see that even when clicked, mobile navigation still has "display: none" style attached, so I thought it was a JS issue. Toggling the CSS in inspector for the nav, displays the menu. |
The problem appears to be caused by Foundation 6.3.1. Previously I couldn't recreate the issue in my local development installation of FoundationPress using Foundation 6.3.0, but I see it now after upgrading to 6.3.1. The issue also goes away when downgrading to 6.3.0. I haven't been able to identify the exact commit that is causing the issue, but here is the comparison between 6.3.0 and 6.3.1. Comparing Changes 6.3.0 to 6.3.1 |
I created a pull request with a simple solution to the issue. However, it looks like all of the pull requests are held up by an issue caused by an update in the WordPress coding standards. I suggest just making the change in your local repos until the pull request gets merged. You can find it here, 7fa7962 |
@EricRihlmann THANK YOU! |
@gbrl can you close this out? |
Fixed 7fa7962 |
How can this bug be reproduced?
What did you expect to happen?
Load website on mobile, click on Hamburger, menu drops down.
What happened instead?
Load website on mobile, click on Hamburger, nothing happens.
Please List the Following:
Mac OS Sierra & iOS (latest versions)
Node version: 7.3.0
Bower:
├── fontawesome#4.5.0 (latest is 4.7.0)
├─┬ foundation-sites#6.3.1
│ ├── jquery#2.2.4 (3.1.1 available)
│ └── what-input#4.0.6 (latest is 4.1.1)
└─┬ motion-ui#1.2.2
└── jquery#2.2.4 (latest is 3.1.1)
Include Test Case (won't be online for very long):
http://foamandthunder.com
The text was updated successfully, but these errors were encountered: