Skip to content
This repository has been archived by the owner on Sep 16, 2019. It is now read-only.

Mobile (hamburger) navigation not responding. #951

Closed
gbrl opened this issue Mar 7, 2017 · 12 comments
Closed

Mobile (hamburger) navigation not responding. #951

gbrl opened this issue Mar 7, 2017 · 12 comments

Comments

@gbrl
Copy link

gbrl commented Mar 7, 2017

How can this bug be reproduced?

  1. Install theme.
  2. Create a few pages and publish them.
  3. Create a menu with a couple pages (Appearance > Menus > "Create a new menu")
  4. Assign the menu to both "Right Top Bar" and "Mobile" positions.
  5. Load website on mobile, click on Hamburger, nothing happens.

What did you expect to happen?

Load website on mobile, click on Hamburger, menu drops down.

What happened instead?

Load website on mobile, click on Hamburger, nothing happens.

Please List the Following:

Mac OS Sierra & iOS (latest versions)

Node version: 7.3.0

Bower:
├── fontawesome#4.5.0 (latest is 4.7.0)
├─┬ foundation-sites#6.3.1
│ ├── jquery#2.2.4 (3.1.1 available)
│ └── what-input#4.0.6 (latest is 4.1.1)
└─┬ motion-ui#1.2.2
└── jquery#2.2.4 (latest is 3.1.1)

Include Test Case (won't be online for very long):
http://foamandthunder.com

@EricRihlmann
Copy link
Contributor

In your example there aren't any mobile menu items in the HTML. Can you post a screenshot of Menu->Manage Locations tab in WP?

@bethanyiam
Copy link

screen shot 2017-03-13 at 3 37 03 pm

@Glenvig
Copy link

Glenvig commented Mar 14, 2017

I'm having the same issue and I haven't solved it yet. Glad if this issue could be fixed.

@linuxbastard
Copy link
Contributor

linuxbastard commented Mar 14, 2017

Hi Guys, chiming in with a question. Can you guys inspect the page in Chrome in mobile mode and check inspector if you are seeing a JS error?

@Glenvig
Copy link

Glenvig commented Mar 14, 2017

No JS error on my site, when I inspect it in mobile mode in Chrome

@gbrl
Copy link
Author

gbrl commented Mar 14, 2017

No errors on my end either.

@linuxbastard
Copy link
Contributor

OK. I'm seeing a JS error on the test case @gbrl posted but it may not be related. I can see that even when clicked, mobile navigation still has "display: none" style attached, so I thought it was a JS issue. Toggling the CSS in inspector for the nav, displays the menu.

@EricRihlmann
Copy link
Contributor

EricRihlmann commented Mar 14, 2017

The problem appears to be caused by Foundation 6.3.1. Previously I couldn't recreate the issue in my local development installation of FoundationPress using Foundation 6.3.0, but I see it now after upgrading to 6.3.1. The issue also goes away when downgrading to 6.3.0. I haven't been able to identify the exact commit that is causing the issue, but here is the comparison between 6.3.0 and 6.3.1.

Comparing Changes 6.3.0 to 6.3.1
foundation/foundation-sites@v6.3.0...v6.3.1

@EricRihlmann
Copy link
Contributor

EricRihlmann commented Mar 14, 2017

I created a pull request with a simple solution to the issue. However, it looks like all of the pull requests are held up by an issue caused by an update in the WordPress coding standards. I suggest just making the change in your local repos until the pull request gets merged.

You can find it here, 7fa7962

@gbrl
Copy link
Author

gbrl commented Mar 14, 2017

@EricRihlmann THANK YOU!

@EricRihlmann
Copy link
Contributor

@gbrl can you close this out?

@olefredrik
Copy link
Owner

Fixed 7fa7962

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants