Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

question about instrument mapping #12

Open
journeytosilius opened this issue Jun 9, 2022 · 1 comment
Open

question about instrument mapping #12

journeytosilius opened this issue Jun 9, 2022 · 1 comment

Comments

@journeytosilius
Copy link

Hey nice tool ! I really want to use it, but I wanted to ask first if it does some kind of mapping according to General Midi specs ?

Like, are the "drums" of a song mapped to one of the drum codes of the GM specs ?

Thanks !

@olefriis
Copy link
Owner

Sorry, for some reason I did not see your issue before. I wasn't trying to be rude by not answering 😄

Yes, there is some mapping going on, which you can see here: https://github.com/olefriis/sidtool/blob/master/lib/sidtool/midi_file_writer.rb#L163-L166

However, all the tool does now is map from the synth type in a SID file to a corresponding MIDI instrument. Often, drums in SID tunes are done using the noise synth in short bursts. Deducing when the noise synth is used as drums is not something sidtool does. The noise synth is mapped to the "strings" MIDI instrument, so drums can sound a bit weird when converted to MIDI 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants