Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with other Languagers then English #9

Open
Shazgul opened this issue May 29, 2024 · 1 comment
Open

Issues with other Languagers then English #9

Shazgul opened this issue May 29, 2024 · 1 comment

Comments

@Shazgul
Copy link

Shazgul commented May 29, 2024

Hey Guys!

What about Multi-Language Support? I saw it struggles with finding the right coloumns if you don't use English as Game Language.

│ │ │ C:\Users\kevin\AppData\Local\Programs\Python\Python312\Lib\site-packages\pandas\core\indexes\bas │ │ e.py:3812 in get_loc │ │ │ │ 3809 │ │ │ │ and any(isinstance(x, slice) for x in casted_key) │ │ 3810 │ │ │ ): │ │ 3811 │ │ │ │ raise InvalidIndexError(key) │ │ ❱ 3812 │ │ │ raise KeyError(key) from err │ │ 3813 │ │ except TypeError: │ │ 3814 │ │ │ # If we have a listlike key, _check_indexing_error will raise │ │ 3815 │ │ │ # InvalidIndexError. Otherwise we fall through and re-raise │ │ │ │ ╭─────────────────────────────────────────── locals ───────────────────────────────────────────╮ │ │ │ casted_key = 'Left Foot' │ │ │ │ key = 'Left Foot' │ │ │ │ self = Index(['Mel', 'Info', 'Name', 'Alter', 'Gehalt', 'Transferwert', 'Nation', │ │ │ │ │ '2. Nation', 'Position', 'Persönlichkeit', 'Medienumgang', 'Ø Note', │ │ │ │ │ 'Linker Fuß', 'Rechter Fuß', 'Größe', 'Eck', 'Fla', 'Dri', 'Abs', 'Ann', │ │ │ │ │ 'Fre', 'Kpf', 'WS', 'Einw', 'Dck', 'Pas', 'Tck', 'Elf', 'Tec', 'Agg', │ │ │ │ │ 'Azp', 'Mut', 'Ner', 'Kon', 'Ent', 'Zie', 'Flr', 'Füh', 'Ohn', 'Ste', │ │ │ │ │ 'Tea', 'Übs', 'Esf', 'Ant', 'Bew', 'Bal', 'Spr', 'Gft', 'Sch', 'Aus', │ │ │ │ │ 'Kra', 'HB', 'StK', 'Kom', 'Exz', 'Hal', 'Abs.1', '1v1', 'Fau', 'Ref', │ │ │ │ │ 'TzH', 'Abw', 'EID', 'Verein'], │ │ │ │ │ dtype='object') │ │ │ ╰──────────────────────────────────────────────────────────────────────────────────────────────╯ │ ╰──────────────────────────────────────────────────────────────────────────────────────────────────╯ KeyError: 'Left Foot'

@olimorris
Copy link
Owner

Yep I suspect this is a shortcoming. Totally up for a PR to fix this.

I don't plan on playing FM24 and am expecting to rewrite this before I pick up FM25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants