Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow skipping when paused #40

Merged

Conversation

dgmstuart
Copy link
Contributor

@dgmstuart dgmstuart commented Mar 3, 2024

Without this, the status doesn't move on until you un-pause.

Not sure if other files should be deleted here as well?

  • TIME_PAUSED_FOR_FILE
  • FROZEN_DISPLAY_FILE

It looks like maybe it doesn't matter if they're hanging around since they're only looked at when resuming from paused (??), but maybe it's good to clean them up, since we're effectively abandoning the paused state here?

Tested by running ./scripts/pomodoro skip, but I'm not sure how to test through Tmux.

Without this, the status doesn't move on until you un-pause.
@dgmstuart dgmstuart force-pushed the dgms/allow-skipping-when-paused branch from f2df04a to 1145565 Compare March 3, 2024 19:30
@dgmstuart
Copy link
Contributor Author

Now tested through tmux with run '~/Code/Shell/tmux-pomodoro-plus/pomodoro.tmux' - seems to work as expected

@olimorris olimorris merged commit 2279303 into olimorris:main Mar 4, 2024
1 check passed
@dgmstuart dgmstuart deleted the dgms/allow-skipping-when-paused branch March 4, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants