Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Action: restart a pomodoro #41

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

dgmstuart
Copy link
Contributor

Sometimes I mess up and don't realise I've already had a timer running.

This adds a binding to restart the timer without incrementing the number of pomodoros or having to skip through a break.

Tested the script part by running ./scripts/pomodoro.sh restart, but I'm not sure how to test through Tmux.

@dgmstuart dgmstuart changed the title Action: restart Pomodoro Action: restart a pomodoro Mar 3, 2024
@olimorris
Copy link
Owner

Firstly, thanks so much for the PR.

In order to test your changes, point your tmux config to the local version of the plugin:

run '~/Code/Shell/tmux-pomodoro-plus/pomodoro.tmux'

Sometimes I mess up and don't realise I've already had a timer running.

This adds a binding to restart the timer without incrementing the number
of pomodoros or having to skip through a break.

Tested the script part by running ./scripts/pomodoro.sh restart, but I'm
not sure how to test through Tmux.
@dgmstuart dgmstuart force-pushed the dgms/restart-a-pomodoro branch from 25f4c53 to 55bdf9a Compare March 3, 2024 23:01
@dgmstuart
Copy link
Contributor Author

Firstly, thanks so much for the PR.

My pleasure!

In order to test your changes, point your tmux config to the local version of the plugin:

run '~/Code/Shell/tmux-pomodoro-plus/pomodoro.tmux'

Nice! I included that in in my .tmux.conf after the run '~/.tmux/plugins/tpm/tpm' (modified to point to the right path on my machine of course) and it runs!

I noticed I left some debug output in there - let me just force-push that out of existence

@dgmstuart
Copy link
Contributor Author

Yup - looks like it works!

@olimorris
Copy link
Owner

Just tested this too. Works great!

@olimorris olimorris merged commit 3aa239d into olimorris:main Mar 4, 2024
@dgmstuart dgmstuart deleted the dgms/restart-a-pomodoro branch March 4, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants