-
-
Notifications
You must be signed in to change notification settings - Fork 760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Follow redirects #789
Follow redirects #789
Conversation
@SaWey please fix lint and add a test if you can |
Fixing lint error
Fix tests
I installed version with this changing and that solve my problem. I think it's good results. |
I'd still like a test so we don't break it in the future. Good to know that it solved the problem though! |
I can't seem to get the test environment setup on my windows machine. How would you see this test being setup? Start a custom server to send a 301 response when loading an image? |
Hi, I'm having an issue that probably will get fixed with this. My url redirects to the actual image but Jimp/phin is reading as XML so it fails. If I test with curl url it shows the xml if I test curl -L url it works like a charm, so please if this gets into Jimp would be awesome |
I was able to add a test with a local server to mock a 301 redirect. |
@hipstersmoothie any idea how I should tackle this testcase? |
@hipstersmoothie |
🚀 PR was released in v0.9.3 🚀 |
Fixes #775
What's Changing and Why
Automatically follow http redirects instead of erroring out.
What else might be affected
Tasks
jimp.d.ts
Published PR with canary version:
0.8.1-canary.789.460.0