Add single frame encoder for type-gif #899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is looking good. get the lint passing and I'll merge 🚀 |
|
Fixed linting @hipstersmoothie |
|
The version for this project is automated through GitHub labels using https://github.com/intuit/auto. Thanks for thinking about it though! |
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's Changing and Why
There wasn't a encoder for image/gif so any attempt to create a buffer with mimetype image/gif would fail with the error Unsupported MIME type: image/gif
What else might be affected
Not sure how things hook up with the getBuffer method so could use some guidance here. All the other encoder functions in the other types seemed synchronous.
Tasks
jimp.d.ts📦 Published PR as canary version:
0.13.0-canary.899.964.0✨ Test out this PR locally via:
npm install @jimp/cli@0.13.0-canary.899.964.0 npm install @jimp/core@0.13.0-canary.899.964.0 npm install @jimp/custom@0.13.0-canary.899.964.0 npm install jimp@0.13.0-canary.899.964.0 npm install @jimp/plugin-blit@0.13.0-canary.899.964.0 npm install @jimp/plugin-blur@0.13.0-canary.899.964.0 npm install @jimp/plugin-circle@0.13.0-canary.899.964.0 npm install @jimp/plugin-color@0.13.0-canary.899.964.0 npm install @jimp/plugin-contain@0.13.0-canary.899.964.0 npm install @jimp/plugin-cover@0.13.0-canary.899.964.0 npm install @jimp/plugin-crop@0.13.0-canary.899.964.0 npm install @jimp/plugin-displace@0.13.0-canary.899.964.0 npm install @jimp/plugin-dither@0.13.0-canary.899.964.0 npm install @jimp/plugin-fisheye@0.13.0-canary.899.964.0 npm install @jimp/plugin-flip@0.13.0-canary.899.964.0 npm install @jimp/plugin-gaussian@0.13.0-canary.899.964.0 npm install @jimp/plugin-invert@0.13.0-canary.899.964.0 npm install @jimp/plugin-mask@0.13.0-canary.899.964.0 npm install @jimp/plugin-normalize@0.13.0-canary.899.964.0 npm install @jimp/plugin-print@0.13.0-canary.899.964.0 npm install @jimp/plugin-resize@0.13.0-canary.899.964.0 npm install @jimp/plugin-rotate@0.13.0-canary.899.964.0 npm install @jimp/plugin-scale@0.13.0-canary.899.964.0 npm install @jimp/plugin-shadow@0.13.0-canary.899.964.0 npm install @jimp/plugin-threshold@0.13.0-canary.899.964.0 npm install @jimp/plugins@0.13.0-canary.899.964.0 npm install @jimp/test-utils@0.13.0-canary.899.964.0 npm install @jimp/bmp@0.13.0-canary.899.964.0 npm install @jimp/gif@0.13.0-canary.899.964.0 npm install @jimp/jpeg@0.13.0-canary.899.964.0 npm install @jimp/png@0.13.0-canary.899.964.0 npm install @jimp/tiff@0.13.0-canary.899.964.0 npm install @jimp/types@0.13.0-canary.899.964.0 npm install @jimp/utils@0.13.0-canary.899.964.0 # or yarn add @jimp/cli@0.13.0-canary.899.964.0 yarn add @jimp/core@0.13.0-canary.899.964.0 yarn add @jimp/custom@0.13.0-canary.899.964.0 yarn add jimp@0.13.0-canary.899.964.0 yarn add @jimp/plugin-blit@0.13.0-canary.899.964.0 yarn add @jimp/plugin-blur@0.13.0-canary.899.964.0 yarn add @jimp/plugin-circle@0.13.0-canary.899.964.0 yarn add @jimp/plugin-color@0.13.0-canary.899.964.0 yarn add @jimp/plugin-contain@0.13.0-canary.899.964.0 yarn add @jimp/plugin-cover@0.13.0-canary.899.964.0 yarn add @jimp/plugin-crop@0.13.0-canary.899.964.0 yarn add @jimp/plugin-displace@0.13.0-canary.899.964.0 yarn add @jimp/plugin-dither@0.13.0-canary.899.964.0 yarn add @jimp/plugin-fisheye@0.13.0-canary.899.964.0 yarn add @jimp/plugin-flip@0.13.0-canary.899.964.0 yarn add @jimp/plugin-gaussian@0.13.0-canary.899.964.0 yarn add @jimp/plugin-invert@0.13.0-canary.899.964.0 yarn add @jimp/plugin-mask@0.13.0-canary.899.964.0 yarn add @jimp/plugin-normalize@0.13.0-canary.899.964.0 yarn add @jimp/plugin-print@0.13.0-canary.899.964.0 yarn add @jimp/plugin-resize@0.13.0-canary.899.964.0 yarn add @jimp/plugin-rotate@0.13.0-canary.899.964.0 yarn add @jimp/plugin-scale@0.13.0-canary.899.964.0 yarn add @jimp/plugin-shadow@0.13.0-canary.899.964.0 yarn add @jimp/plugin-threshold@0.13.0-canary.899.964.0 yarn add @jimp/plugins@0.13.0-canary.899.964.0 yarn add @jimp/test-utils@0.13.0-canary.899.964.0 yarn add @jimp/bmp@0.13.0-canary.899.964.0 yarn add @jimp/gif@0.13.0-canary.899.964.0 yarn add @jimp/jpeg@0.13.0-canary.899.964.0 yarn add @jimp/png@0.13.0-canary.899.964.0 yarn add @jimp/tiff@0.13.0-canary.899.964.0 yarn add @jimp/types@0.13.0-canary.899.964.0 yarn add @jimp/utils@0.13.0-canary.899.964.0