From e60bc2ef941ecb8087950e1b078a8d94098abefa Mon Sep 17 00:00:00 2001 From: Bryan Oliver Date: Thu, 11 Aug 2022 11:40:52 -0400 Subject: [PATCH] fix: messy promises, TODO - more err handling cleanup --- dist/index.js | 8 ++++++-- lib/helpers.js | 8 ++++++-- 2 files changed, 12 insertions(+), 4 deletions(-) diff --git a/dist/index.js b/dist/index.js index fcc1d8c..5daa719 100644 --- a/dist/index.js +++ b/dist/index.js @@ -5,6 +5,7 @@ /***/ ((module, __unused_webpack_exports, __nccwpck_require__) => { const {Octokit} = __nccwpck_require__(1231) +const core = __nccwpck_require__(2186); const octokit = new Octokit(); function uniq(a) { @@ -34,14 +35,17 @@ async function getRepoTeams(org, repo) { return Promise.resolve(data .filter(team => teamHasWrite(team.permission)) .map(team => team.name) - ); + ).catch(err => { core.setFailed(err) }); } async function getUserIsApprover(org, repo, user) { const repoTeams = await getRepoTeams(org, repo); teamsArrays = await Promise.all( repoTeams.map(team => getTeamUsers(team)) - ); + ).catch((err) => { + console.error(err) + core.setFailed(err); + }); const allApprovingUsers = teamsArrays .reduce((acc, arr) => acc.concat(arr)); diff --git a/lib/helpers.js b/lib/helpers.js index 4d5ff17..1c98bee 100644 --- a/lib/helpers.js +++ b/lib/helpers.js @@ -1,4 +1,5 @@ const {Octokit} = require('@octokit/action') +const core = require('@actions/core'); const octokit = new Octokit(); function uniq(a) { @@ -28,14 +29,17 @@ async function getRepoTeams(org, repo) { return Promise.resolve(data .filter(team => teamHasWrite(team.permission)) .map(team => team.name) - ); + ).catch(err => { core.setFailed(err) }); } async function getUserIsApprover(org, repo, user) { const repoTeams = await getRepoTeams(org, repo); teamsArrays = await Promise.all( repoTeams.map(team => getTeamUsers(team)) - ); + ).catch((err) => { + console.error(err) + core.setFailed(err); + }); const allApprovingUsers = teamsArrays .reduce((acc, arr) => acc.concat(arr));